Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 23537005: Update class and interface cycle tests (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
Reviewers:
ngeoffray, kustermann
CC:
reviews_dartlang.org, ahe, ngeoffray
Visibility:
Public.

Description

Update class and interface cycle tests Updated two tests from negative tests to multi-tests. Ensured the involved classes where actualy instantiated. Extended the test to use the bad class as a type argument as well. R=kustermann@google.com, ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26862

Patch Set 1 #

Patch Set 2 : Style change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -84 lines) Patch
A + tests/language/class_cycle2_test.dart View 1 1 chunk +8 lines, -14 lines 0 comments Download
D tests/language/class_cycle_negative_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/language/interface_cycle_negative_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
A + tests/language/interface_cycle_test.dart View 1 1 chunk +8 lines, -15 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-08-29 11:56:01 UTC) #1
kustermann
LGTM
7 years, 3 months ago (2013-08-29 12:00:53 UTC) #2
ngeoffray
LGTM
7 years, 3 months ago (2013-08-29 12:05:23 UTC) #3
Søren Gjesse
7 years, 3 months ago (2013-08-29 12:06:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26862 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698