Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 23537003: - Allow the collection of intermediate values during long BigintOperations. (Closed)

Created:
7 years, 3 months ago by Ivan Posva
Modified:
7 years, 3 months ago
Reviewers:
floitsch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Allow the collection of intermediate values during long BigintOperations. R=asiva@google.com, floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=26798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/bigint_operations.cc View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
We'll need to find other expensive operations, but these are triggered when printing BigInts. -Ivan
7 years, 3 months ago (2013-08-28 05:31:06 UTC) #1
floitsch
LGTM.
7 years, 3 months ago (2013-08-28 09:09:06 UTC) #2
siva
lgtm
7 years, 3 months ago (2013-08-28 15:45:40 UTC) #3
Ivan Posva
7 years, 3 months ago (2013-08-28 16:03:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r26798 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698