Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2048)

Issue 23536032: Revert "Simplify process exit-code handling on Posix." (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Simplify process exit-code handling on Posix." This reverts commit f1b1ba410e964b0f787513f245faf8b457c9331a. BUG= Committed: https://code.google.com/p/dart/source/detail?r=27251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -126 lines) Patch
M runtime/bin/process_android.cc View 5 chunks +124 lines, -42 lines 0 comments Download
M runtime/bin/process_linux.cc View 5 chunks +124 lines, -42 lines 0 comments Download
M runtime/bin/process_macos.cc View 4 chunks +123 lines, -42 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Anders Johnsen
TBR I'm not 100% happy with the impl. Reverting for now.
7 years, 3 months ago (2013-09-06 15:02:18 UTC) #1
Anders Johnsen
7 years, 3 months ago (2013-09-06 15:02:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r27251 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698