Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 235343004: Accelerate old-space growth (Closed)

Created:
6 years, 8 months ago by koda
Modified:
6 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use history to estimate what fraction of allocation will be garbage => grow more when less garbage was collected. Change semantics of heap_growth_rate flag to mean *maximum* number of pages we grow. Allow more initial growth before first mark-sweep => many small programs will avoid mark-sweep. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35410

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -51 lines) Patch
M runtime/vm/pages.h View 1 2 3 4 4 chunks +7 lines, -12 lines 0 comments Download
M runtime/vm/pages.cc View 1 2 3 4 3 chunks +47 lines, -39 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
koda
6 years, 8 months ago (2014-04-22 00:10:43 UTC) #1
koda
Updated with an "initial gc timeout" to avoid wasting space for slow-allocating isolates. With current ...
6 years, 8 months ago (2014-04-22 16:44:43 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/235343004/diff/80001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/235343004/diff/80001/runtime/vm/pages.cc#newcode683 runtime/vm/pages.cc:683: Heap* heap = Isolate::Current()->heap(); The PSC should ...
6 years, 8 months ago (2014-04-24 17:44:18 UTC) #3
koda
https://codereview.chromium.org/235343004/diff/80001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/235343004/diff/80001/runtime/vm/pages.cc#newcode683 runtime/vm/pages.cc:683: Heap* heap = Isolate::Current()->heap(); On 2014/04/24 17:44:18, Ivan Posva ...
6 years, 8 months ago (2014-04-24 18:07:45 UTC) #4
koda
6 years, 8 months ago (2014-04-24 22:30:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r35410 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698