Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Issue 23534043: Don't wait for asynchronous error handlers. (Closed)

Created:
7 years, 3 months ago by floitsch
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't wait for asynchronous error handlers. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=27182

Patch Set 1 #

Patch Set 2 : Use _asyncSetError. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
M sdk/lib/async/future_impl.dart View 1 7 chunks +4 lines, -31 lines 1 comment Download
M tests/lib/async/catch_errors15_test.dart View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
7 years, 3 months ago (2013-09-04 12:29:00 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/23534043/diff/3001/sdk/lib/async/future_impl.dart File sdk/lib/async/future_impl.dart (right): https://codereview.chromium.org/23534043/diff/3001/sdk/lib/async/future_impl.dart#newcode325 sdk/lib/async/future_impl.dart:325: var error = _resultOrListeners; Why the alias for ...
7 years, 3 months ago (2013-09-05 09:17:25 UTC) #2
floitsch
https://codereview.chromium.org/23534043/diff/3001/tests/lib/async/catch_errors15_test.dart File tests/lib/async/catch_errors15_test.dart (right): https://codereview.chromium.org/23534043/diff/3001/tests/lib/async/catch_errors15_test.dart#newcode40 tests/lib/async/catch_errors15_test.dart:40: // global order. On 2013/09/05 09:17:25, Lasse Reichstein Nielsen ...
7 years, 3 months ago (2013-09-05 09:23:08 UTC) #3
floitsch
7 years, 3 months ago (2013-09-05 09:25:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27182 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698