Issue 23533074: Support "[as ...]" in V8 stack traces in pkg/stack_trace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23533074: Support "[as ...]" in V8 stack traces in pkg/stack_trace. (Closed)

Created:
7 years, 3 months ago by nweiz

Modified:
6 years, 7 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support "[as ...]" in V8 stack traces in pkg/stack_trace. BUG=13431

Patch Set 3 : Fix tests #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	pkg/stack_trace/lib/src/frame.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	pkg/stack_trace/test/frame_test.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

https://codereview.chromium.org/23533074/diff/1/pkg/stack_trace/test/frame_test.dart File pkg/stack_trace/test/frame_test.dart (right): https://codereview.chromium.org/23533074/diff/1/pkg/stack_trace/test/frame_test.dart#newcode77 pkg/stack_trace/test/frame_test.dart:77: solo_test('parses a stack frame with [as ...] correctly', () ...

7 years, 3 months ago (2013-09-20 19:14:46 UTC) #2

nweiz

7 years, 3 months ago (2013-09-20 19:29:09 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 23533074: Support "[as ...]" in V8 stack traces in pkg/stack_trace. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix tess #

Patch Set 3 : Fix tests #

Messages