Issue 23532066: dart:io | Change creation of symbolic links with relative targets on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23532066: dart:io | Change creation of symbolic links with relative targets on Windows. (Closed)

Created:
7 years, 3 months ago by Bill Hesse

Modified:
7 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Change creation of symbolic links with relative targets on Windows. A relative path to a target directory on Windows is changed to an absolute path, joining the relative path to the directory the link is contained in. BUG=dartbug.com/13279 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27566

Patch Set 1 #

Patch Set 2 : Add testing #

Patch Set 3 : Add tests for relative links to all platforms. #

Patch Set 4 : Fix Windows relative links. #

Patch Set 5 : Drop .. and . segments from Windows link targets. #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -18 lines)			Patch
M	sdk/lib/io/link.dart	View	1 2 3 4	2 chunks	+9 lines, -14 lines	0 comments	Download
M	tests/standalone/io/link_async_test.dart	View	1 2	3 chunks	+39 lines, -4 lines	1 comment	Download
M	tests/standalone/io/link_test.dart	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/23532066/diff/10001/tests/standalone/io/link_async_test.dart File tests/standalone/io/link_async_test.dart (right): https://codereview.chromium.org/23532066/diff/10001/tests/standalone/io/link_async_test.dart#newcode275 tests/standalone/io/link_async_test.dart:275: new File(filePath).exists().then((exists) => Expect.isTrue(exists)); (exists) => Expect.isTrue(exists) can ...

7 years, 3 months ago (2013-09-17 11:55:29 UTC) #2

Bill Hesse

7 years, 3 months ago (2013-09-17 12:21:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r27566 (presubmit successful).

Expand Messages | Collapse Messages