Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 23531079: Revert "Reapply r27640: "Emit compile-time error on duplicate parameter names in typedefs."" (Closed)

Created:
7 years, 3 months ago by karlklose
Modified:
7 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Reapply r27640: "Emit compile-time error on duplicate parameter names in typedefs."" This reverts commit r27693. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=27696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -46 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 4 chunks +28 lines, -36 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 3 months ago (2013-09-20 10:34:56 UTC) #1
karlklose
Committed patchset #1 manually as r27696 (presubmit successful).
7 years, 3 months ago (2013-09-20 10:36:02 UTC) #2
Johnni Winther
7 years, 3 months ago (2013-09-20 10:46:52 UTC) #3
Message was sent while issue was closed.
LGTM :(

Powered by Google App Engine
This is Rietveld 408576698