Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Issue 23531063: Check that constant locals have constant initializers. (Closed)

Created:
7 years, 3 months ago by Johnni Winther
Modified:
7 years, 2 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Check that constant locals have constant initializers. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=28093

Patch Set 1 #

Patch Set 2 : Remove blank lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
A tests/language/constant_locals_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 3 months ago (2013-09-18 15:47:30 UTC) #1
karlklose
LGTM.
7 years, 3 months ago (2013-09-19 11:36:13 UTC) #2
Johnni Winther
7 years, 2 months ago (2013-10-01 11:48:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r28093 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698