Issue 23531008: Last round of cleanups in exception handler, before going to the next stage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23531008: Last round of cleanups in exception handler, before going to the next stage. (Closed)

Created:
7 years, 3 months ago by srdjan

Modified:
7 years, 3 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Last round of cleanups in exception handler, before going to the next stage. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26941

Patch Set 4 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -35 lines)			Patch
M	runtime/vm/code_descriptors.h	View	1 2 3	2 chunks	+14 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	3 chunks	+12 lines, -19 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 2 3	2 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/stack_frame.cc	View	1 2 3	1 chunk	+12 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/23531008/diff/15001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/23531008/diff/15001/runtime/vm/object.cc#newcode8308 runtime/vm/object.cc:8308: *info = raw_ptr()->data_[try_index]; WIll this structure assignment work ...

7 years, 3 months ago (2013-08-30 04:15:19 UTC) #2

srdjan

https://codereview.chromium.org/23531008/diff/15001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/23531008/diff/15001/runtime/vm/object.cc#newcode8308 runtime/vm/object.cc:8308: *info = raw_ptr()->data_[try_index]; On 2013/08/30 04:15:19, siva wrote: > ...

7 years, 3 months ago (2013-08-30 20:43:47 UTC) #3

srdjan

7 years, 3 months ago (2013-08-30 20:47:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r26941 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23531008: Last round of cleanups in exception handler, before going to the next stage. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages