Make Dart_ScriptGetTokenInfo account for line_offset() and col_offset()

Make Dart_ScriptGetTokenInfo account for line_offset() and col_offset()


Cleanup bugs in wrapExpressionAsClosure Fix bug in how setters were handled and filter out 'this' from local variables list.

BUG=
R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27581

[Jacob, 2013-09-17 18:24:59]

There are no existing tests in the VM for this API.
When the dartium CL that is blocked by this change lands there will be a dartium
test that exercises this code.

If this change looks reasonable I can add a test to 
debugger_api_impl_test.cc that exercises this code.

[hausner, 2013-09-17 18:55:25]

LGTM.

[Jacob, 2013-09-17 19:44:21]

PTAL. I've switched over to storing columnNumber instead of charOffset. I've
synced with Devon and updated the relevant line of code in the editor (comment
only change). The editor wasn't using charOffset at all so this change should
have no impact except for unblocking showing the correct columnNumber in the
chrome devtools.

[hausner, 2013-09-17 20:01:52]

Please adjust the comment that deals with line number table in
tools/coverage.dart (around line 80). It refers to the character offset rather
than column. I think the value is not used, it's just that the comment is now
wrong.

[hausner, 2013-09-17 20:02:04]

Oh, and LGTM (again)

[Jacob, 2013-09-17 20:52:50]

Committed patchset #3 manually as r27581 (presubmit successful).