Issue 23526020: Fix inferrer bug in the presence of compound assignments and unresolved fields in a generative cons…

Issue 23526020: Fix inferrer bug in the presence of compound assignments and unresolved fields in a generative cons… (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix inferrer bug in the presence of compound assignments and unresolved fields in a generative constructor. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=27185

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -10 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1	7 chunks	+32 lines, -10 lines	0 comments	Download
	A	tests/language/inferrer_this_access_test.dart	View		1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/23526020/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/23526020/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode1854 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1854: || (element != null && element.isInstanceMember())) { Make ...

7 years, 3 months ago (2013-09-05 09:39:15 UTC) #2

ngeoffray

Thanks Johnni. https://codereview.chromium.org/23526020/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/23526020/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode1854 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1854: || (element != null && element.isInstanceMember())) { ...

7 years, 3 months ago (2013-09-05 09:46:55 UTC) #3

ngeoffray

7 years, 3 months ago (2013-09-05 09:51:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27185 (presubmit successful).

Expand Messages | Collapse Messages