Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23525003: Safe DOM w/ fixes (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

This is an updated version of https://codereview.chromium.org/16374007/ Original submission is the first patch, fixes are the second. There were two issues with the original- - Issue with URI sanitization where relative URIs on IE were being dropped. - Analyzer issue on missing members for CustomElement. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26757

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6657 lines, -2685 lines) Patch
M pkg/custom_element/lib/custom_element.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/custom_element/test/custom_element_test.dart View 2 chunks +9 lines, -1 line 0 comments Download
M pkg/mdv/test/custom_element_bindings_test.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/mdv/test/template_element_test.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/unittest/lib/html_enhanced_config.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 12 chunks +2194 lines, -1061 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 13 chunks +2439 lines, -1301 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 4 chunks +54 lines, -38 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 4 chunks +54 lines, -38 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/html/custom/document_register_basic_test.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M tests/html/custom/document_register_type_extensions_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/html/custom_elements_test.dart View 4 chunks +9 lines, -3 lines 0 comments Download
M tests/html/custom_tags_test.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M tests/html/element_test.dart View 11 chunks +25 lines, -19 lines 0 comments Download
A tests/html/node_validator_test.dart View 1 chunk +424 lines, -0 lines 0 comments Download
M tests/html/safe_dom_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/svg_test.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M tests/html/svgelement_test.dart View 3 chunks +8 lines, -6 lines 0 comments Download
M tests/html/utils.dart View 2 chunks +37 lines, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +0 lines, -1 line 0 comments Download
A tools/dom/src/Html5NodeValidator.dart View 1 chunk +450 lines, -0 lines 0 comments Download
A tools/dom/src/NodeValidatorBuilder.dart View 1 chunk +453 lines, -0 lines 0 comments Download
A tools/dom/src/Validators.dart View 1 2 1 chunk +204 lines, -0 lines 0 comments Download
M tools/dom/src/shared_SVGFactoryProviders.dart View 2 chunks +1 line, -29 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +8 lines, -5 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +8 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 2 chunks +16 lines, -20 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +134 lines, -124 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate View 1 chunk +16 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 2 chunks +48 lines, -9 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGSVGElement.darttemplate View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 3 months ago (2013-08-27 19:53:27 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/23525003/diff/3001/tools/dom/src/Validators.dart File tools/dom/src/Validators.dart (right): https://codereview.chromium.org/23525003/diff/3001/tools/dom/src/Validators.dart#newcode109 tools/dom/src/Validators.dart:109: if (Device.isIE && Would this logic work without ...
7 years, 3 months ago (2013-08-27 20:12:12 UTC) #2
blois
https://codereview.chromium.org/23525003/diff/3001/tools/dom/src/Validators.dart File tools/dom/src/Validators.dart (right): https://codereview.chromium.org/23525003/diff/3001/tools/dom/src/Validators.dart#newcode109 tools/dom/src/Validators.dart:109: if (Device.isIE && On 2013/08/27 20:12:12, John Messerly wrote: ...
7 years, 3 months ago (2013-08-27 21:08:32 UTC) #3
Jennifer Messerly
Makes sense. This new version LGTM too.
7 years, 3 months ago (2013-08-27 22:57:25 UTC) #4
blois
7 years, 3 months ago (2013-08-28 01:03:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r26757 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698