Issue 23523039: Fix the flag --reorder-basic-blocks so it works to disable reordering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23523039: Fix the flag --reorder-basic-blocks so it works to disable reordering. (Closed)

Created:
7 years, 3 months ago by Kevin Millikin (Google)

Modified:
7 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix the flag --reorder-basic-blocks so it works to disable reordering. Temporarily set the flag to false by default to avoid a bad interaction between block reordering and empty block compaction (dartbug.com/13101). BUG=https://code.google.com/p/dart/issues/detail?id=13101 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=27292

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -5 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

7 years, 3 months ago (2013-09-09 14:55:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27292 (presubmit successful).

Expand Messages | Collapse Messages