Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 23522030: Don't use Uri's isAbsolute to detect if the path segment is absolute, in toFilePath. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use Uri's isAbsolute to detect if the path segment is absolute, in toFilePath. BUG=https://code.google.com/p/dart/issues/detail?id=13126 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M sdk/lib/core/uri.dart View 3 chunks +7 lines, -2 lines 0 comments Download
M tests/co19/co19-co19.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 3 months ago (2013-09-12 08:27:13 UTC) #1
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-12 08:36:43 UTC) #2
Anders Johnsen
7 years, 3 months ago (2013-09-12 08:45:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698