Issue 23519005: Change test language/const_factory_negative_test.dart into a multi-test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23519005: Change test language/const_factory_negative_test.dart into a multi-test (Closed)

Created:
7 years, 3 months ago by Søren Gjesse

Modified:
6 years, 11 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change test language/const_factory_negative_test.dart into a multi-test R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27174

Patch Set 2 : Addressed review comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -26 lines)			Patch
D	tests/language/const_factory_negative_test.dart	View		1 chunk	+0 lines, -14 lines	0 comments	Download
A +	tests/language/const_factory_with_body_test.dart	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		2 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM https://codereview.chromium.org/23519005/diff/1/tests/language/const_factory_with_body_test.dart File tests/language/const_factory_with_body_test.dart (right): https://codereview.chromium.org/23519005/diff/1/tests/language/const_factory_with_body_test.dart#newcode5 tests/language/const_factory_with_body_test.dart:5: // For DartC: tests that a "const factory" ...

7 years, 3 months ago (2013-09-04 14:22:25 UTC) #2

Søren Gjesse

7 years, 3 months ago (2013-09-05 07:01:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r27174 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23519005: Change test language/const_factory_negative_test.dart into a multi-test (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages