Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 23514061: Cleanup bugs in wrapExpressionAsClosure Fix bug in how setters were handled and filter out 'this' f… (Closed)

Created:
7 years, 3 months ago by Jacob
Modified:
7 years, 3 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleanup bugs in wrapExpressionAsClosure Fix bug in how setters were handled and filter out 'this' from local variables list. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=27576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +14 lines, -4 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jacob
7 years, 3 months ago (2013-09-17 00:49:11 UTC) #1
vsm
lgtm
7 years, 3 months ago (2013-09-17 00:55:18 UTC) #2
Jacob
7 years, 3 months ago (2013-09-17 17:08:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27576 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698