Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 23513029: Updating Dartium status and IE9 status (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updating Dartium status and IE9 status Dartium tests started passing because changes for polyfill triggered expected behavior for Dartium, even though the bug is still active. Updated tests for some IE9 expectations, but still failing and needs further investigation. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=27321

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M tests/html/custom/document_register_type_extensions_test.dart View 9 chunks +17 lines, -10 lines 2 comments Download
M tests/html/html.status View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 3 months ago (2013-09-09 23:34:25 UTC) #1
blois
Committed patchset #1 manually as r27321 (presubmit successful).
7 years, 3 months ago (2013-09-09 23:34:47 UTC) #2
Jennifer Messerly
7 years, 3 months ago (2013-09-10 02:21:04 UTC) #3
Message was sent while issue was closed.
https://codereview.chromium.org/23513029/diff/1/tests/html/custom/document_re...
File tests/html/custom/document_register_type_extensions_test.dart (right):

https://codereview.chromium.org/23513029/diff/1/tests/html/custom/document_re...
tests/html/custom/document_register_type_extensions_test.dart:15:
'<?XML:NAMESPACE PREFIX = PUBLIC NS = "URN:COMPONENT" /><x-foo></x-foo>'];
what ... the ... heck? :)  is this some new spec craziness?

https://codereview.chromium.org/23513029/diff/1/tests/html/custom/document_re...
tests/html/custom/document_register_type_extensions_test.dart:29:
'<?XML:NAMESPACE PREFIX = PUBLIC NS = "URN:COMPONENT" /><x-baz></x-baz>'];
maybe put this XML thingy in a constant

Powered by Google App Engine
This is Rietveld 408576698