Issue 23513010: Make HashMap constructor a factory.

Issue 23513010: Make HashMap constructor a factory. (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make HashMap constructor a factory. Add optional parameters that aren't supported yet. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=27044

Patch Set 2 : Address review comments. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -7 lines)			Patch
M	pkg/serialization/lib/src/serialization_helpers.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/lib/collection_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/collection_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/collection/hash_map.dart	View	1	2 chunks	+40 lines, -1 line	0 comments	Download
M	tests/language/issue10561_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/issue9949_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/23513010/diff/1/sdk/lib/collection/hash_map.dart File sdk/lib/collection/hash_map.dart (right): https://codereview.chromium.org/23513010/diff/1/sdk/lib/collection/hash_map.dart#newcode25 sdk/lib/collection/hash_map.dart:25: * Creates an unordered hash-table based [Map]. I'm ...

7 years, 3 months ago (2013-09-03 11:19:49 UTC) #2

Lasse Reichstein Nielsen

m https://codereview.chromium.org/23513010/diff/1/sdk/lib/collection/hash_map.dart File sdk/lib/collection/hash_map.dart (right): https://codereview.chromium.org/23513010/diff/1/sdk/lib/collection/hash_map.dart#newcode25 sdk/lib/collection/hash_map.dart:25: * Creates an unordered hash-table based [Map]. On ...

7 years, 3 months ago (2013-09-03 11:44:28 UTC) #3

Lasse Reichstein Nielsen

7 years, 3 months ago (2013-09-03 11:45:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27044 (presubmit successful).

Expand Messages | Collapse Messages