Issue 23512004: Revert "Compress memory usage. Imprive speed of finding exception handle..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23512004: Revert "Compress memory usage. Imprive speed of finding exception handle..." (Closed)

Created:
7 years, 3 months ago by Kevin Millikin (Google)

Modified:
7 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Compress memory usage. Imprive speed of finding exception handle..." This reverts svn revision 26880. That change has broken stack traces for exceptions, making it impossible to use them for debugging Dart code. BUG=https://code.google.com/p/dart/issues/detail?id=12940 Committed: https://code.google.com/p/dart/source/detail?r=26909

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -47 lines)			Patch
M	runtime/vm/exceptions.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+8 lines, -16 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/raw_object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stack_frame.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

Committed patchset #1 manually as r26909 (presubmit successful).

7 years, 3 months ago (2013-08-30 11:19:33 UTC) #2

Kevin Millikin (Google)

On 2013/08/30 11:19:33, kmillikin wrote: > Committed patchset #1 manually as r26909 (presubmit successful). Committed ...

7 years, 3 months ago (2013-08-30 11:19:51 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages