Add div displaying the currently executing test.

Add div displaying the currently executing test.

This can be useful if the window freezes up with a busy loop

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27027

[kustermann, 2013-09-03 07:20:24]

Please also add notification area -- to eliminate the alert boxes.

https://codereview.chromium.org/23506023/diff/1/tools/testing/dart/browser_co...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/23506023/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:51: factory Browser.byName(String
name, [String binaryLocation]) {
unused variable!

https://codereview.chromium.org/23506023/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:462: static const String _binary =
"firefox";
This doesn't work. looking at line 484, you still use 'binary'.

https://codereview.chromium.org/23506023/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:1058:
document.getElementById('currently_executing').innerHTML = url;
There's actually no need to query it again and again.
You can just do what we do with the iframe above (line 1007).

[ricow1, 2013-09-03 07:27:22]

https://codereview.chromium.org/23506023/diff/1/tools/testing/dart/browser_co...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/23506023/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:51: factory Browser.byName(String
name, [String binaryLocation]) {
On 2013/09/03 07:20:24, kustermann wrote:
> unused variable!

Not meant for this cl

https://codereview.chromium.org/23506023/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:462: static const String _binary =
"firefox";
On 2013/09/03 07:20:24, kustermann wrote:
> This doesn't work. looking at line 484, you still use 'binary'.
Sure, again unrelated

https://codereview.chromium.org/23506023/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:1058:
document.getElementById('currently_executing').innerHTML = url;
On 2013/09/03 07:20:24, kustermann wrote:
> There's actually no need to query it again and again.
> You can just do what we do with the iframe above (line 1007).

Done.

[kustermann, 2013-09-03 07:35:15]

LGTM with comments

+1 for removing the alert() boxes!

https://codereview.chromium.org/23506023/diff/8001/tools/testing/dart/browser...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/23506023/diff/8001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:51: factory Browser.byName(String
name, [String binaryLocation]) {
Unused variable!

https://codereview.chromium.org/23506023/diff/8001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:462: static const String _binary =
"firefox";
You still use 'binary'!

[ricow1, 2013-09-03 08:04:32]

Committed patchset #3 manually as r27027 (presubmit successful).