Issue 23505006: co19-roll to r559

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23505006: co19-roll to r559 (Closed)

Created:
7 years, 3 months ago by kustermann

Modified:
7 years, 3 months ago

Reviewers:
ricow1, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

co19-roll to r559 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=26799

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+618 lines, -266 lines)			Patch
M	dart/tests/co19/co19-analyzer.status	View		12 chunks	+2 lines, -58 lines	0 comments	Download
M	dart/tests/co19/co19-analyzer2.status	View		10 chunks	+197 lines, -32 lines	0 comments	Download
M	dart/tests/co19/co19-co19.status	View	1	8 chunks	+262 lines, -24 lines	1 comment	Download
M	dart/tests/co19/co19-dart2dart.status	View		14 chunks	+12 lines, -48 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	1 2	13 chunks	+114 lines, -50 lines	0 comments	Download
M	dart/tests/co19/co19-runtime.status	View	1 2	10 chunks	+30 lines, -53 lines	0 comments	Download
M	deps/all.deps/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

Committed patchset #3 manually as r26799 (presubmit successful).

7 years, 3 months ago (2013-08-28 16:33:00 UTC) #3

Ivan Posva

7 years, 3 months ago (2013-08-28 17:42:41 UTC) #4

Message was sent while issue was closed.

Thanks!

-Ivan

https://codereview.chromium.org/23505006/diff/5001/dart/tests/co19/co19-co19....
File dart/tests/co19/co19-co19.status (right):

https://codereview.chromium.org/23505006/diff/5001/dart/tests/co19/co19-co19....
dart/tests/co19/co19-co19.status:325: Language/15_Types/1_Static_Types_A03_t01:
Fail # co19-roll r559: Please triage this failure
Who is supposed to triage these issues in the co19-co19.status files?

Expand Messages | Collapse Messages