Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 23503035: Emit a compile-time error on const constructors with a body. (Closed)

Created:
7 years, 3 months ago by karlklose
Modified:
7 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Emit a compile-time error on const constructors with a body. BUG=dartbug.com/13028 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=27194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +11 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 2 chunks +12 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 3 months ago (2013-09-05 11:50:53 UTC) #1
Johnni Winther
lgtm
7 years, 3 months ago (2013-09-05 12:13:13 UTC) #2
karlklose
7 years, 3 months ago (2013-09-05 12:45:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698