Issue 23499007: HTML types that don't have [] do not implement JavaScriptIndexingBehavior, that is, the items canno…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23499007: HTML types that don't have [] do not implement JavaScriptIndexingBehavior, that is, the items canno… (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
karlklose, blois, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

HTML types that don't have [] do not implement JavaScriptIndexingBehavior, that is, the items cannot be accessed through [] in JavaScript. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=26911

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -19 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1	3 chunks	+11 lines, -7 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/svg_dart2js.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

ngeoffray

+Karl, whose type inference CL is blocked by the bug fixed by this CL.

7 years, 3 months ago (2013-08-30 11:40:37 UTC) #2

ngeoffray

7 years, 3 months ago (2013-08-30 13:27:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26911 (presubmit successful).