Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 23496027: Fix analyzer_experimental hints: remove unused imports. (Closed)

Created:
7 years, 3 months ago by scheglov
Modified:
7 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix analyzer_experimental hints: remove unused imports. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26944

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -55 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 10 chunks +0 lines, -26 lines 0 comments Download
M pkg/analyzer_experimental/example/parser_driver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/example/scanner_driver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/html.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/sdk.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/sdk_io.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source_io.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/services/formatter.dart View 1 chunk +1 line, -1 line 1 comment Download
M pkg/analyzer_experimental/test/generated/ast_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/element_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/parser_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/test_support.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/test/options_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 3 months ago (2013-08-30 16:09:52 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/23496027/diff/1/pkg/analyzer_experimental/lib/src/services/formatter.dart File pkg/analyzer_experimental/lib/src/services/formatter.dart (right): https://codereview.chromium.org/23496027/diff/1/pkg/analyzer_experimental/lib/src/services/formatter.dart#newcode7 pkg/analyzer_experimental/lib/src/services/formatter.dart:7: //import 'package:analyzer_experimental/src/services/formatter_impl.dart'; I don't think we should change ...
7 years, 3 months ago (2013-08-30 16:22:32 UTC) #2
scheglov
7 years, 3 months ago (2013-08-30 21:11:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26944 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698