Issue 23495020: @proxy support the Analysis Engine.

Issue 23495020: @proxy support the Analysis Engine. (Closed)

Created:
7 years, 3 months ago by jwren

Modified:
7 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

@proxy support the Analysis Engine. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=26981

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+361 lines, -43 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View		14 chunks	+69 lines, -24 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryResolver.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ProxyConditionalAnalysisError.java	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java	View		4 chunks	+58 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ScopedVisitor.java	View		2 chunks	+18 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View		2 chunks	+91 lines, -13 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/23495020/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java (right): https://codereview.chromium.org/23495020/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java#newcode1241 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java:1241: for (ProxyConditionalAnalysisError conditionalCode : resolverVisitor.getProxyConditionalAnalysisErrors()) { It would ...

7 years, 3 months ago (2013-08-30 22:12:38 UTC) #2

jwren

7 years, 3 months ago (2013-08-31 20:19:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r26981 (presubmit successful).

Expand Messages | Collapse Messages