Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 23494066: Automatically converted general Fail status file markers to one of the more specific markers (Closed)

Created:
7 years, 3 months ago by kustermann
Modified:
7 years, 2 months ago
Reviewers:
ricow1, Johnni Winther, ahe
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Automatically converted general Fail status file markers to one of the more specific markers R=johnniwinther@google.com, ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=27876

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -327 lines) Patch
M pkg/pkg.status View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 9 chunks +116 lines, -116 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 chunks +116 lines, -116 lines 1 comment Download
M tests/lib/lib.status View 1 2 2 chunks +62 lines, -62 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kustermann
7 years, 3 months ago (2013-09-24 10:57:46 UTC) #1
ricow1
It would be really beneficial to state _how_ you automatically marked these. (=> add tool ...
7 years, 3 months ago (2013-09-24 11:12:55 UTC) #2
kustermann
I'll need to tweek it a bit more, so please wait before taking a closer ...
7 years, 3 months ago (2013-09-24 11:14:22 UTC) #3
Johnni Winther
lgtm
7 years, 3 months ago (2013-09-24 11:18:39 UTC) #4
kustermann
Now you can take a look. There are a lot more 'fail' markers in the ...
7 years, 2 months ago (2013-09-25 12:31:18 UTC) #5
ricow1
LGTM https://codereview.chromium.org/23494066/diff/14001/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/23494066/diff/14001/tests/language/language_dart2js.status#newcode45 tests/language/language_dart2js.status:45: compile_time_constant_checked_test/02: MissingCompileTimeError, OK Peter, maybe you guys want ...
7 years, 2 months ago (2013-09-25 12:42:43 UTC) #6
kustermann
7 years, 2 months ago (2013-09-25 12:47:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r27876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698