Issue 23494026: Change inlined stack frame iterator to use code and pc instead of frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23494026: Change inlined stack frame iterator to use code and pc instead of frame. (Closed)

Created:
7 years, 3 months ago by srdjan

Modified:
7 years, 3 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change inlined stack frame iterator to use code and pc instead of frame. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27140

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	runtime/lib/stacktrace.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/exceptions.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/simulator_arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stack_frame.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stack_frame.cc	View	1	1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/23494026/diff/1/runtime/vm/stack_frame.cc File runtime/vm/stack_frame.cc (right): https://codereview.chromium.org/23494026/diff/1/runtime/vm/stack_frame.cc#newcode353 runtime/vm/stack_frame.cc:353: object_table_(Array::Handle()) { Need an assertion here to ensure ...

7 years, 3 months ago (2013-09-04 19:32:42 UTC) #2

srdjan

https://codereview.chromium.org/23494026/diff/1/runtime/vm/stack_frame.cc File runtime/vm/stack_frame.cc (right): https://codereview.chromium.org/23494026/diff/1/runtime/vm/stack_frame.cc#newcode353 runtime/vm/stack_frame.cc:353: object_table_(Array::Handle()) { On 2013/09/04 19:32:42, siva wrote: > Need ...

7 years, 3 months ago (2013-09-04 19:36:03 UTC) #3

srdjan

7 years, 3 months ago (2013-09-04 19:36:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27140 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23494026: Change inlined stack frame iterator to use code and pc instead of frame. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages