Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 23493017: Reapply "Add custom equals and hashCode for HashMap implementation." (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ngeoffray
Visibility:
Public.

Description

Reapply "Add custom equals and hashCode for HashMap implementation." Committed: https://code.google.com/p/dart/source/detail?r=27179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -75 lines) Patch
M runtime/lib/collection_patch.dart View 9 chunks +227 lines, -17 lines 0 comments Download
M sdk/lib/_internal/lib/collection_patch.dart View 10 chunks +70 lines, -18 lines 0 comments Download
M sdk/lib/collection/hash_map.dart View 4 chunks +11 lines, -40 lines 0 comments Download
M tests/corelib/map_test.dart View 3 chunks +241 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein Nielsen
7 years, 3 months ago (2013-09-04 11:49:37 UTC) #1
ngeoffray
I find it easier to review when you re-apply to have the first patchset be ...
7 years, 3 months ago (2013-09-04 11:50:44 UTC) #2
Lasse Reichstein Nielsen
Usualy yes, but there was no new fix here. The bug that caused the revert ...
7 years, 3 months ago (2013-09-04 14:27:30 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 manually as r27179 (presubmit successful).
7 years, 3 months ago (2013-09-05 08:29:36 UTC) #4
Lasse Reichstein Nielsen
TBR. Reapplying now that blocking dart2js bug was fixed.
7 years, 3 months ago (2013-09-05 09:18:14 UTC) #5
floitsch
7 years, 3 months ago (2013-09-05 09:21:40 UTC) #6
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698