Issue 23493007: - Avoid doubly implementing Function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23493007: - Avoid doubly implementing Function. (Closed)

Created:
7 years, 3 months ago by Ivan Posva

Modified:
7 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Avoid doubly implementing Function. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=26716

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+0 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://codereview.chromium.org/23493007/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (left): https://codereview.chromium.org/23493007/diff/1/runtime/vm/object.cc#oldcode2187 runtime/vm/object.cc:2187: // Implements interface "Function". The interface Function is implemented ...

7 years, 3 months ago (2013-08-27 16:07:46 UTC) #1

Ivan Posva

7 years, 3 months ago (2013-08-27 16:15:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26716 (presubmit successful).

Expand Messages | Collapse Messages