Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 23493006: Remove dart:utf in third_party. (Closed)

Created:
7 years, 3 months ago by floitsch
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Forgot to update pubspec. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pkg/third_party/html5lib/lib/dom_parsing.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/third_party/html5lib/lib/src/char_encodings.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/third_party/html5lib/lib/src/inputstream.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/third_party/html5lib/pubspec.yaml View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/third_party/html5lib/test/tokenizer_test.dart View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
Not sure how to update third_party packages. This is, what should be done.
7 years, 3 months ago (2013-08-27 15:51:51 UTC) #1
floitsch
Forgot to update the pubspec file.
7 years, 3 months ago (2013-08-27 15:52:56 UTC) #2
Jennifer Messerly
LGTM, thank you! Feel free to commit it directly.
7 years, 3 months ago (2013-08-27 17:45:40 UTC) #3
floitsch
7 years, 3 months ago (2013-08-28 15:40:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698