Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 234843003: Make server-sockets level triggered. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen
Modified:
6 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make server-sockets level triggered. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35302

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix platforms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -27 lines) Patch
M runtime/bin/eventhandler_android.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 5 chunks +33 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
Please look, and I'll port it to the other platforms as well.
6 years, 8 months ago (2014-04-11 11:08:58 UTC) #1
Søren Gjesse
lgtm for Linux
6 years, 8 months ago (2014-04-11 11:57:09 UTC) #2
Anders Johnsen
PTAL, added other platforms.
6 years, 8 months ago (2014-04-22 11:15:24 UTC) #3
Søren Gjesse
lgtm
6 years, 8 months ago (2014-04-22 11:51:05 UTC) #4
Anders Johnsen
6 years, 8 months ago (2014-04-23 06:05:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r35302 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698