Issue 23484033: Avoid name collision with reserved word

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23484033: Avoid name collision with reserved word (Closed)

Created:
7 years, 3 months ago by Alan Knight

Modified:
7 years, 3 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid name collision with reserved word R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=27399

Patch Set 2 : Renamed prefix #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	pkg/intl/lib/generate_localized.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	pkg/intl/test/message_extraction/foo_messages_all.dart	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

The locale 'in' was a problem with the previous library names.

7 years, 3 months ago (2013-09-11 18:48:36 UTC) #1

Emily Fortuna

lgtm https://codereview.chromium.org/23484033/diff/1/pkg/intl/lib/generate_localized.dart File pkg/intl/lib/generate_localized.dart (right): https://codereview.chromium.org/23484033/diff/1/pkg/intl/lib/generate_localized.dart#newcode88 pkg/intl/lib/generate_localized.dart:88: String _libraryName(String x) => 'lib_' + x.replaceAll('-', '_'); ...

7 years, 3 months ago (2013-09-11 19:47:43 UTC) #2

Alan Knight

7 years, 3 months ago (2013-09-11 20:04:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r27399 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23484033: Avoid name collision with reserved word (Closed)

Description

Patch Set 1 #

Patch Set 2 : Renamed prefix #

Messages