Issue 23480093: Recommit add FileSystemEntity.resolveSymbolicLinks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23480093: Recommit add FileSystemEntity.resolveSymbolicLinks (Closed)

Created:
7 years, 3 months ago by Bill Hesse

Modified:
7 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Recommit add FileSystemEntity.resolveSymbolicLinks This was reverted in r27481 because of a failure on the debug Windows VM buildbot. BUG=dartbug.com/1016 Committed: https://code.google.com/p/dart/source/detail?r=27612

Patch Set 1 #

Patch Set 2 : Fix assertion failure on Windows #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+288 lines, -60 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/file_patch.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/file_system_entity_patch.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/file_win.cc	View	1	1 chunk	+37 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/io/directory.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/io/file.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View		2 chunks	+3 lines, -22 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View		3 chunks	+64 lines, -1 line	0 comments	Download
M	sdk/lib/io/link.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/standalone/io/file_error_test.dart	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View		2 chunks	+0 lines, -11 lines	0 comments	Download
A	tests/standalone/io/resolve_symbolic_links_test.dart	View		1 chunk	+147 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Identical to the previously committed version, except for the one assert changed in file_win.cc. It ...

7 years, 3 months ago (2013-09-18 12:14:55 UTC) #1

lgtm

Expand Messages | Collapse Messages