Issue 23479025: Implement reflection on function type aliases (typedef).

Issue 23479025: Implement reflection on function type aliases (typedef). (Closed)

Created:
7 years, 3 months ago by ahe

Modified:
5 years, 10 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, rmacnak, Michael Lippautz (Google), karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement reflection on function type aliases (typedef). BUG=http://dartbug.com/11612 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=27204

Patch Set 3 : ParameterMirror.isStatic #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+262 lines, -3 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		1 chunk	+13 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1 2	4 chunks	+123 lines, -2 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
A	dart/tests/lib/mirrors/typedef_test.dart	View	1	1 chunk	+113 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

This test doesn't work on the VM yet, and minified mode doesn't preserve names. But ...

7 years, 3 months ago (2013-09-04 03:41:02 UTC) #1

ahe

The test is now complete. I'll deal with minification in another CL.

7 years, 3 months ago (2013-09-05 12:10:17 UTC) #3

Johnni Winther

lgtm https://codereview.chromium.org/23479025/diff/7001/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/23479025/diff/7001/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode1390 dart/sdk/lib/_internal/lib/js_mirrors.dart:1390: return m.isStatic; Is that the intended semantics? Shouldn't ...

7 years, 3 months ago (2013-09-05 12:36:48 UTC) #4

ahe

7 years, 3 months ago (2013-09-05 17:55:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r27204 (presubmit successful).

Expand Messages | Collapse Messages