Issue 23479022: Make sure to never report SocketExceptions on HttpResponse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23479022: Make sure to never report SocketExceptions on HttpResponse. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen

Modified:
7 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, ricow1, kustermann

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Make sure to never report SocketExceptions on HttpResponse. This fixes a case where the system might not fail on sending data, but first fail on closing the socket. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27039

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -3 lines)			Patch
M	sdk/lib/io/http_impl.dart	View	3 chunks	+7 lines, -3 lines	0 comments	Download
A	tests/standalone/io/http_server_close_response_after_error_client.dart	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	tests/standalone/io/http_server_close_response_after_error_test.dart	View	1 chunk	+37 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Anders Johnsen

7 years, 3 months ago (2013-09-03 11:06:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27039 (presubmit successful).