Rewrite two tests to multi-tests

Rewrite two tests to multi-tests

R=ahe@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=26904

[Søren Gjesse, 2013-08-27 11:19:21]

The two tests was re-written to multi-tests. This removed the checking of the
actual runtime error thrown, but adds check of static type warnings.

Please check if the expectations in the test are correct. When they are I will
update the CL with actual issue numbers for the filed bugs (in place of XXX).

The rewrite also removes the check of the content of the exception toString
result and stacktrace which I think should go away under all circumstances.

[ahe, 2013-08-27 18:31:18]

https://chromiumcodereview.appspot.com/23479005/diff/1/tests/language/named_p...
File tests/language/named_parameters_type_test.dart (right):

https://chromiumcodereview.appspot.com/23479005/diff/1/tests/language/named_p...
tests/language/named_parameters_type_test.dart:4: //
VMOptions=--enable_type_checks
I don't think this is going to work on dart2js.

https://chromiumcodereview.appspot.com/23479005/diff/1/tests/language/named_p...
tests/language/named_parameters_type_test.dart:21:
acceptFunNumOptBool(funNumOptBool);  /// 01: ok
Is this a new multi-test tag?

[Søren Gjesse, 2013-08-28 11:31:24]

PTAL

https://codereview.chromium.org/23479005/diff/1/tests/language/named_paramete...
File tests/language/named_parameters_type_test.dart (right):

https://codereview.chromium.org/23479005/diff/1/tests/language/named_paramete...
tests/language/named_parameters_type_test.dart:4: //
VMOptions=--enable_type_checks
On 2013/08/27 18:31:18, ahe wrote:
> I don't think this is going to work on dart2js.

It does not affect dart2js, but makes the VM always run in checked mode (changed
it to --checked). The test requires checked mode to generate the runtime errors,
and this is how this is handled in other tests as well. For dart2js these tests
are listed with status "Fail, OK" in the section [ $compiler == dart2js &&
$unchecked ]. I am not saying this is ideal, but it is the current way of
handling this.

https://codereview.chromium.org/23479005/diff/1/tests/language/named_paramete...
tests/language/named_parameters_type_test.dart:21:
acceptFunNumOptBool(funNumOptBool);  /// 01: ok
On 2013/08/27 18:31:18, ahe wrote:
> Is this a new multi-test tag?

It is not - I found it in other tests. However it is not really needed here, as
this line can just be in all instances of this test, so I removed this comment.

[ahe, 2013-08-30 06:05:23]

LGTM!

https://codereview.chromium.org/23479005/diff/17001/tests/language/named_para...
File tests/language/named_parameters_type_test.dart (right):

https://codereview.chromium.org/23479005/diff/17001/tests/language/named_para...
tests/language/named_parameters_type_test.dart:4: // VMOptions=--checked
I still think this is wrong. Parts of this test should be "Fail, OK" in
unchecked mode.

[Søren Gjesse, 2013-08-30 08:23:10]

https://codereview.chromium.org/23479005/diff/17001/tests/language/named_para...
File tests/language/named_parameters_type_test.dart (right):

https://codereview.chromium.org/23479005/diff/17001/tests/language/named_para...
tests/language/named_parameters_type_test.dart:4: // VMOptions=--checked
On 2013/08/30 06:05:23, ahe wrote:
> I still think this is wrong. Parts of this test should be "Fail, OK" in
> unchecked mode.

I opened issue https://code.google.com/p/dart/issues/detail?id=12927 on this.

[Søren Gjesse, 2013-08-30 08:43:11]

Committed patchset #6 manually as r26904 (presubmit successful).