Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 23479002: Suppressing first-chance exception in path_observer. (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Suppressing first-chance exception in path_observer. The exception is thrown and caught in Dartium but the debugger still stops on this line when first-chance exceptions are enabled. I opened bug 12776 on this, but specifying the radix will suppress the exception. Note that this sends the code down what's called the 'slowParse'. See https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/runtime/lib/integers_patch.dart#83 BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/observe/lib/src/path_observer.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 3 months ago (2013-08-26 21:39:02 UTC) #1
Jennifer Messerly
lgtm! nice workaround
7 years, 3 months ago (2013-08-26 21:51:13 UTC) #2
blois
7 years, 3 months ago (2013-08-26 21:54:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698