Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 23478007: Mark bunch of pub tests as flaky. (Closed)

Created:
7 years, 3 months ago by zarah
Modified:
7 years, 3 months ago
Reviewers:
ricow1, Søren Gjesse
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Mark bunch of pub tests as flaky. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=26775

Patch Set 1 #

Total comments: 6

Patch Set 2 : Added ':' . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M sdk/lib/_internal/pub/pub.status View 1 1 chunk +14 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zarah
7 years, 3 months ago (2013-08-28 08:16:47 UTC) #1
ricow1
LGTM with 3 : added https://codereview.chromium.org/23478007/diff/1/sdk/lib/_internal/pub/pub.status File sdk/lib/_internal/pub/pub.status (right): https://codereview.chromium.org/23478007/diff/1/sdk/lib/_internal/pub/pub.status#newcode16 sdk/lib/_internal/pub/pub.status:16: test/install/hosted/unlock_if_incompatible_test Pass, Fail # ...
7 years, 3 months ago (2013-08-28 08:19:12 UTC) #2
Søren Gjesse
https://codereview.chromium.org/23478007/diff/1/sdk/lib/_internal/pub/pub.status File sdk/lib/_internal/pub/pub.status (right): https://codereview.chromium.org/23478007/diff/1/sdk/lib/_internal/pub/pub.status#newcode6 sdk/lib/_internal/pub/pub.status:6: test/oauth2/with_an_expired_credentials_refreshes_and_saves_test: Pass, Fail # Issue 12581 Are there any ...
7 years, 3 months ago (2013-08-28 08:28:13 UTC) #3
ricow1
https://codereview.chromium.org/23478007/diff/1/sdk/lib/_internal/pub/pub.status File sdk/lib/_internal/pub/pub.status (right): https://codereview.chromium.org/23478007/diff/1/sdk/lib/_internal/pub/pub.status#newcode6 sdk/lib/_internal/pub/pub.status:6: test/oauth2/with_an_expired_credentials_refreshes_and_saves_test: Pass, Fail # Issue 12581 On 2013/08/28 08:28:13, ...
7 years, 3 months ago (2013-08-28 08:59:03 UTC) #4
zarah
Committed patchset #2 manually as r26775 (presubmit successful).
7 years, 3 months ago (2013-08-28 09:32:56 UTC) #5
zarah
7 years, 3 months ago (2013-08-28 10:17:19 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/23478007/diff/1/sdk/lib/_internal/pub/pub.status
File sdk/lib/_internal/pub/pub.status (right):

https://codereview.chromium.org/23478007/diff/1/sdk/lib/_internal/pub/pub.sta...
sdk/lib/_internal/pub/pub.status:16:
test/install/hosted/unlock_if_incompatible_test Pass, Fail # Issue 12837
On 2013/08/28 08:19:12, ricow1 wrote:
> you are missing a : after the test here, + the two lines below

Done.

Powered by Google App Engine
This is Rietveld 408576698