Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 23478005: Add compilation error on named parameters with private names (Closed)

Created:
7 years, 3 months ago by hausner
Modified:
7 years, 3 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Add compilation error on named parameters with private names Remove bogus test cases. Fixes issue 5743, 3502 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26719

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -138 lines) Patch
M runtime/vm/parser.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/named_parameters_with_object_property_names_test.dart View 2 chunks +0 lines, -132 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 3 months ago (2013-08-27 00:21:39 UTC) #1
srdjan
lgtm
7 years, 3 months ago (2013-08-27 00:50:42 UTC) #2
hausner
7 years, 3 months ago (2013-08-27 16:41:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r26719 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698