Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23477028: Remove dart2js_foreign. (Closed)

Created:
7 years, 3 months ago by ahe
Modified:
7 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2925 lines) Patch
D dart/tests/compiler/dart2js_foreign/dart2js_foreign.status View 1 chunk +0 lines, -5 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/foreign_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_call_arity1_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_call_arity2_test.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_call_arity3_test.dart View 1 chunk +0 lines, -86 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_checked_arguments1_test.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_checked_fields_test.dart View 1 chunk +0 lines, -120 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_class_inheritance1_test.dart View 1 chunk +0 lines, -109 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_class_inheritance2_test.dart View 1 chunk +0 lines, -86 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_class_inheritance3_test.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_class_inheritance4_test.dart View 1 chunk +0 lines, -151 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_class_is_check1_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_class_is_check3_test.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_class_with_dart_methods_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_closure_identity_test.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_exceptions1_test.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_field_rename_1_test.dart View 1 chunk +0 lines, -85 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_field_rename_2_test.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib1.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_library_same_name_used_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_literal_class_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_metadata.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_method_rename1_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_method_rename2_test.dart View 1 chunk +0 lines, -87 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_method_rename3_test.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_method_with_keyword_name_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_missing_method1_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_missing_method2_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_named_constructors2_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_named_constructors3_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_no_such_method_exception2_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_no_such_method_exception3_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_no_such_method_exception4_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_no_such_method_exception5_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_no_such_method_exception_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_null_closure_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_null_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_parameter_names_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_property_test.dart View 1 chunk +0 lines, -70 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_to_string_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_use_native_name_in_table_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_window1_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_window2_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_wrapping_function2_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_wrapping_function3_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D dart/tests/compiler/dart2js_foreign/native_wrapping_function_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
M dart/tools/bots/compiler.py View 1 chunk +1 line, -1 line 0 comments Download
M dart/tools/test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
dart2js_foreign was a failed experiment I started. dart2js_native is moving closer towards something like that.
7 years, 3 months ago (2013-09-02 18:52:45 UTC) #1
kustermann
Changes to tools/ LGTM, although I don't really know what dart2js_foreign used to test and ...
7 years, 3 months ago (2013-09-03 07:23:33 UTC) #2
ahe
7 years, 3 months ago (2013-09-03 08:42:06 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r27032 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698