Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 23477003: Getters and setters must also be added to the list of intercepted names, to make invocations throug… (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Getters and setters must also be added to the list of intercepted names, to make invocations through Function.apply and mirrors know the right calling convetion. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=26763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 2 chunks +10 lines, -2 lines 0 comments Download
A tests/compiler/dart2js_native/mirror_intercepted_field_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 3 months ago (2013-08-27 07:50:29 UTC) #1
ahe
LGTM!
7 years, 3 months ago (2013-08-27 18:49:18 UTC) #2
ngeoffray
7 years, 3 months ago (2013-08-28 06:26:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26763 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698