Issue 23475003: Further fixes from Safe HTML integration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23475003: Further fixes from Safe HTML integration (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Further fixes from Safe HTML integration The table construction tests are failing on IE9 because innerHTML isn't supported on IE9 The png_layout test (only run on Dartium) is failing because inline styles are not supported by default. BUG= Committed: https://code.google.com/p/dart/source/detail?r=26761

Patch Set 1 : #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	tests/utils/png_layout_test.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r26761 (presubmit successful).

7 years, 3 months ago (2013-08-28 02:12:10 UTC) #2

Jennifer Messerly

7 years, 3 months ago (2013-08-28 02:20:42 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/23475003/diff/3001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/23475003/diff/3001/tests/html/html.status#new...
tests/html/html.status:148: element_test/constructors: Fail         # IE9 does
not support innerHTML on table elements
is there a bug filed for this? it seems like a pretty bad regression

Expand Messages | Collapse Messages