Issue 234743004: Update expectations after adding timer to d8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234743004: Update expectations after adding timer to d8. (Closed)

Created:
6 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update expectations after adding timer to d8. Add remaining features of Date object to mock. Committed: https://code.google.com/p/dart/source/detail?r=34970

Patch Set 2 : Removed one line too many #

Patch Set 3 : One test more moved to both d8 and jsshell #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -38 lines)			Patch
	M	sdk/lib/_internal/lib/preambles/d8.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tests/co19/co19-dart2js.status	View	1 2	1 chunk	+32 lines, -38 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://codereview.chromium.org/234743004/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (left): https://codereview.chromium.org/234743004/diff/1/tests/co19/co19-dart2js.status#oldcode948 tests/co19/co19-dart2js.status:948: [ $compiler == dart2js && $runtime == d8 ] ...

6 years, 8 months ago (2014-04-11 12:06:26 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #3 manually as r34970 (presubmit successful).

6 years, 8 months ago (2014-04-11 12:15:44 UTC) #4

Message was sent while issue was closed.

lgtm