Add FileSystemEntity.absolutePath and .isAbsolute properties.

Add FileSystemEntity.absolutePath and .isAbsolute properties.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27467

[Bill Hesse, 2013-09-12 14:43:46]

Adding absolutePath should encourage people to use it rather than
resolveSymbolicLinks to get an absolute path to something.  Most internal uses
of fullPath (deprecated in the resolveSymbolicLinks CL) will be replaced with
absolutePath.

[Anders Johnsen, 2013-09-12 15:09:24]

Quick comment (will do a full review tomorrow):

I'm not sure if FileSystemEntity should have an isAbsolute. With it, we are sort
of merging Uri/path methods into the FileSystemEntity, changing its domain from
being purely IO calls, to also serve as a String manipulator.

I'm also thinking that absolutePath is sort of in the same ballpark, with one
exception: The current directory live in dart:io. If that changes (were moved to
e.g. Uri.base), this method would have nothing to do with dart:io.

Could we instead make sure Uri have the right functions needed?

[Bill Hesse, 2013-09-13 06:33:40]

On 2013/09/12 15:09:24, Anders Johnsen wrote:
> Quick comment (will do a full review tomorrow):
> 
> I'm not sure if FileSystemEntity should have an isAbsolute. With it, we are
sort
> of merging Uri/path methods into the FileSystemEntity, changing its domain
from
> being purely IO calls, to also serve as a String manipulator.
> 
> I'm also thinking that absolutePath is sort of in the same ballpark, with one
> exception: The current directory live in dart:io. If that changes (were moved
to
> e.g. Uri.base), this method would have nothing to do with dart:io.
> 
> Could we instead make sure Uri have the right functions needed?

We could use instead Uri's functions, to write this as
new Uri.file(Directory.current.path).resolveUri(new Uri.file(x)).toFilePath()

But then there is still the question of where to put it, and getting the CWD on
all configurations.

It seems that getting CWD available across all configurations is needed for
this, and to remove mirrors from package path.

[Søren Gjesse, 2013-09-13 06:49:43]

On 2013/09/13 06:33:40, Bill Hesse wrote:
> On 2013/09/12 15:09:24, Anders Johnsen wrote:
> > Quick comment (will do a full review tomorrow):
> > 
> > I'm not sure if FileSystemEntity should have an isAbsolute. With it, we are
> sort
> > of merging Uri/path methods into the FileSystemEntity, changing its domain
> from
> > being purely IO calls, to also serve as a String manipulator.
> > 
> > I'm also thinking that absolutePath is sort of in the same ballpark, with
one
> > exception: The current directory live in dart:io. If that changes (were
moved
> to
> > e.g. Uri.base), this method would have nothing to do with dart:io.
> > 
> > Could we instead make sure Uri have the right functions needed?
> 
> We could use instead Uri's functions, to write this as
> new Uri.file(Directory.current.path).resolveUri(new Uri.file(x)).toFilePath()
> 
> But then there is still the question of where to put it, and getting the CWD
on
> all configurations.
> 
> It seems that getting CWD available across all configurations is needed for
> this, and to remove mirrors from package path.

I think we should provide these methods on FileSystemEntity. When working with
simple IO code just using this makes sense.

[Søren Gjesse, 2013-09-13 06:49:48]

lgtm

[Søren Gjesse, 2013-09-13 06:56:08]

https://codereview.chromium.org/23468027/diff/6001/sdk/lib/io/file_system_ent...
File sdk/lib/io/file_system_entity.dart (right):

https://codereview.chromium.org/23468027/diff/6001/sdk/lib/io/file_system_ent...
sdk/lib/io/file_system_entity.dart:369: String get absolutePath {
Thinking about this once more. Shouldn't this return a FileSystemEntiry of the
same type of the receiver instead of a String? And be called just absolute then?

File a = new File("a").absolute();

[Bill Hesse, 2013-09-13 08:56:29]

Committed patchset #4 manually as r27467 (presubmit successful).