Reduce test.dart memory usage.

Reduce test.dart memory usage.

BUG=dartbug.com/18084
R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35313

[kustermann, 2014-04-11 15:17:37]

https://codereview.chromium.org/234673003/diff/20001/tools/testing/dart/test_...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/234673003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_progress.dart:535: }
I think you shouldn't do that. If two test cases (e.g. dart2js-ff and
dart2js-chrome) share the same compilation command, and one of them finished,
you can't delete the output: If the other one fails and you print the output,
the compilation output will be null!

[Bill Hesse, 2014-04-11 15:35:11]

On 2014/04/11 15:17:37, kustermann wrote:
>
https://codereview.chromium.org/234673003/diff/20001/tools/testing/dart/test_...
> File tools/testing/dart/test_progress.dart (right):
> 
>
https://codereview.chromium.org/234673003/diff/20001/tools/testing/dart/test_...
> tools/testing/dart/test_progress.dart:535: }
> I think you shouldn't do that. If two test cases (e.g. dart2js-ff and
> dart2js-chrome) share the same compilation command, and one of them finished,
> you can't delete the output: If the other one fails and you print the output,
> the compilation output will be null!

This is right. We need to be able to look at the dependency graph, and only
delete the output for a command if all tests using it have been reported.  I'll
adjust the CL to do this.

[Bill Hesse, 2014-04-23 14:52:40]

Removed the test output deletion.  All that is left is changing
TestUtils.dartDir to a getter, and caching it, and running test.dart in
unchecked mode, by Ivan's request.

https://codereview.chromium.org/234673003/diff/20001/tools/testing/dart/test_...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/234673003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_progress.dart:535: }
On 2014/04/11 15:17:37, kustermann wrote:
> I think you shouldn't do that. If two test cases (e.g. dart2js-ff and
> dart2js-chrome) share the same compilation command, and one of them finished,
> you can't delete the output: If the other one fails and you print the output,
> the compilation output will be null!

Removing the code that deletes test output.  Leaving just the minor changes in
this cl.

[ricow1, 2014-04-23 14:58:34]

LGTM except I don't think we should remove the checked mode

https://codereview.chromium.org/234673003/diff/40001/tools/test.py
File tools/test.py (right):

https://codereview.chromium.org/234673003/diff/40001/tools/test.py#newcode22
tools/test.py:22: command = [utils.DartBinary(), dart_test_script] + args
I don't like this, this is catching issues for us before submitting, and I don't
see the test.dart being the bottleneck

[Bill Hesse, 2014-04-23 15:07:54]

Committed patchset #3 manually as r35313 (presubmit successful).

[Bill Hesse, 2014-04-23 15:08:06]

https://codereview.chromium.org/234673003/diff/40001/tools/test.py
File tools/test.py (right):

https://codereview.chromium.org/234673003/diff/40001/tools/test.py#newcode22
tools/test.py:22: command = [utils.DartBinary(), dart_test_script] + args
On 2014/04/23 14:58:34, ricow1 wrote:
> I don't like this, this is catching issues for us before submitting, and I
don't
> see the test.dart being the bottleneck

Agreed.  Removed.