Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 23465004: More cleanup related to malformed and malbounded types. (Closed)

Created:
7 years, 3 months ago by regis
Modified:
7 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

More cleanup related to malformed and malbounded types. Remove support for warnings in parser and related flags. Rename flag --error-on-malformed-type to --error-on-bad-type, since it covers both malformed and malbounded types (also closer to --error-on-bad-override). R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=26677

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -146 lines) Patch
M runtime/tools/create_snapshot_bin.py View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 1 15 chunks +32 lines, -32 lines 0 comments Download
M runtime/vm/object.cc View 1 39 chunks +86 lines, -86 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 11 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
7 years, 3 months ago (2013-08-26 21:43:25 UTC) #1
hausner
LGTM but see comment. I think we should keep Warning(). https://codereview.chromium.org/23465004/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (left): https://codereview.chromium.org/23465004/diff/1/runtime/vm/parser.cc#oldcode7015 ...
7 years, 3 months ago (2013-08-26 22:17:33 UTC) #2
regis
Thanks! https://codereview.chromium.org/23465004/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (left): https://codereview.chromium.org/23465004/diff/1/runtime/vm/parser.cc#oldcode7015 runtime/vm/parser.cc:7015: void Parser::Warning(intptr_t token_pos, const char* format, ...) { ...
7 years, 3 months ago (2013-08-26 23:23:38 UTC) #3
regis
7 years, 3 months ago (2013-08-26 23:24:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26677 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698