Issue 23464040: Remove String.concat from implementation classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23464040: Remove String.concat from implementation classes. (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove String.concat from implementation classes. It was removed from the interface a long time ago. BUG= http://dartbug.com/13128 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=27286

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	runtime/lib/string_patch.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	sdk/lib/_internal/lib/js_string.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Lasse Reichstein Nielsen

7 years, 3 months ago (2013-09-09 11:04:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27286 (presubmit successful).