Issue 23463044: Remove duplicated code on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23463044: Remove duplicated code on Windows (Closed)

Created:
7 years, 3 months ago by Søren Gjesse

Modified:
7 years, 3 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove duplicated code on Windows This also gives a litle more info when FormatMessageW fails. R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27639

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -27 lines)			Patch
M	runtime/bin/builtin_impl_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/process_win.cc	View	2 chunks	+2 lines, -15 lines	0 comments	Download
A +	runtime/bin/utils_win.h	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	runtime/bin/utils_win.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

7 years, 3 months ago (2013-09-19 06:33:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27639 (presubmit successful).