Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 23461044: Fix to NOT traverse linked directories when formatting (dartbug.com/13187). (Closed)

Created:
7 years, 3 months ago by pquitslund
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix to NOT traverse linked directories when formatting (dartbug.com/13187). We *may* allow support for this in the future but either way the default (as set here) should be false. R=brianwilkerson@google.com, kevmoo@j832.com Committed: https://code.google.com/p/dart/source/detail?r=27349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/analyzer_experimental/bin/formatter.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pquitslund
7 years, 3 months ago (2013-09-10 18:27:52 UTC) #1
kevmoo-old
On 2013/09/10 18:27:52, pquitslund wrote: LGTM ...and thanks!
7 years, 3 months ago (2013-09-10 18:30:07 UTC) #2
Brian Wilkerson
LGTM
7 years, 3 months ago (2013-09-10 18:30:44 UTC) #3
pquitslund
7 years, 3 months ago (2013-09-10 18:32:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r27349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698